The tests need to be updated to match this change.

I can't test this with these containers, since nginx is getting pulled from nginx repo which does not have the latest nginx package. Locally we are testing with latest version, since it is required for this PR.
@kenyon how do I proceed from here?

You can specify an nginx version in an acceptance test's puppet code, just like in regular puppet code. Since the http2 directive doesn't exist in older versions, I think you have to have some logic that only uses it if the nginx version is 1.25.1 or newer.

@kenyon Hey, can you tell me why archlinux is the only test failing? It seems like other Pull Requests have the same problem.

@C24-AK Archlinux test failure is expected for now.

@kenyon Hey, what to do on following error?
This happens outside of examples:

JSON::ParserError:
unexpected token at ''
./vendor/bundle/ruby/2.7.0/gems/json-2.6.3/lib/json/common.rb:216:in parse' ./vendor/bundle/ruby/2.7.0/gems/json-2.6.3/lib/json/common.rb:216:in parse'
./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-4.0.0/lib/rspec-puppet/coverage.rb:99:in load_filters' ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-4.0.0/lib/rspec-puppet/coverage.rb:80:in block in merge_filters'
./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-4.0.0/lib/rspec-puppet/coverage.rb:79:in each' ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-4.0.0/lib/rspec-puppet/coverage.rb:79:in merge_filters'
./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-4.0.0/lib/rspec-puppet/coverage.rb:201:in run_report' ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-4.0.0/lib/rspec-puppet/coverage.rb:186:in report!'
./vendor/bundle/ruby/2.7.0/gems/voxpupuli-test-7.0.2/lib/voxpupuli/test/spec_helper.rb:21:in `block (2 levels) in <top (required)>'

Yeah I don't know what is causing that. Some debugging required.

Is this something I need to fix for this PR to be merged?

That looks better, thanks! (Edit: The archlinux failure seems unrelated)

Can you please combine your 40+ commits in a single one?

From your working directory:

git rebase -i origin/main # Interactively rewrite history

This will bring your editor listing all commits in your branch. Keep the first line unchanged, and replace pick with squash for all subsequent lines. Save and quit, your editor will pop again and allow you to combine all the commit messages in a single one.

Then push your updated branch:

git push -f            # Send the changes (-f is required because we re-wrote history)

Hey @smortex,

I did what you explained and it feels like all my changes are gone?
All tests are failing

Edit: I reverted it, should be fixed.

@smortex anything else to do or am I finished here?

@smortex anything else to do or am I finished here?

That look good, the failures seems unrelated, I tried to run the test again, maybe it will pass and if not maybe this will ring a bell to some other contributor?

I added an in-line note about old test removal, and I wonder if we can keep them for now?

@smortex I resolved your comment and added the tests

I just reran the failing Puppet 7 job to see if it's consistent.

I'm not sure how this change would be causing this error, but it seems like it is.

From https://github.com/voxpupuli/puppet-nginx/actions/runs/6809552993/job/18546775611?pr=1579#step:5:299

An error occurred in an `after(:suite)` hook.
Failure/Error: Parser.new(source, **(opts||{})).parse

JSON::ParserError:
  unexpected token at ''
# ./vendor/bundle/ruby/2.7.0/gems/json-2.6.3/lib/json/common.rb:216:in `parse'
# ./vendor/bundle/ruby/2.7.0/gems/json-2.6.3/lib/json/common.rb:216:in `parse'
# ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-4.0.0/lib/rspec-puppet/coverage.rb:99:in `load_filters'
# ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-4.0.0/lib/rspec-puppet/coverage.rb:80:in `block in merge_filters'
# ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-4.0.0/lib/rspec-puppet/coverage.rb:79:in `each'
# ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-4.0.0/lib/rspec-puppet/coverage.rb:79:in `merge_filters'
# ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-4.0.0/lib/rspec-puppet/coverage.rb:201:in `run_report'
# ./vendor/bundle/ruby/2.7.0/gems/rspec-puppet-4.0.0/lib/rspec-puppet/coverage.rb:186:in `report!'
# ./vendor/bundle/ruby/2.7.0/gems/voxpupuli-test-7.0.2/lib/voxpupuli/test/spec_helper.rb:21:in `block (2 levels) in <top (required)>'

@kenyon I am not very familiar with this. How would I fix this issue? I appreciate any help

Is this rdy to merge? @kenyon